Implement dask collection protocol on HealpixDataset#1252
Closed
Implement dask collection protocol on HealpixDataset#1252
Conversation
Add __dask_graph__, __dask_keys__, __dask_tokenize__, __dask_postcompute__, __dask_postpersist__, __dask_optimize__, and __dask_scheduler__ methods to HealpixDataset, delegating to the underlying _ddf NestedFrame. This allows dask.distributed.Client.compute(catalog) to return a Future instead of requiring users to access the internal _ddf attribute. Fixes #1028 https://claude.ai/code/session_013NNQnzZHryYqUC1eAWFC5w
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1252 +/- ##
==========================================
- Coverage 96.67% 96.62% -0.06%
==========================================
Files 48 48
Lines 2949 2963 +14
==========================================
+ Hits 2851 2863 +12
- Misses 98 100 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Verify that a Catalog is recognized as a dask collection and that dask.compute() returns the correct result, matching _ddf.compute(). https://claude.ai/code/session_013NNQnzZHryYqUC1eAWFC5w
Click here to view all benchmarks. |
Update test to use dask.distributed.Client and assert that the return value is a Future, which is the core of issue #1028. https://claude.ai/code/session_013NNQnzZHryYqUC1eAWFC5w
Move Client import to conftest.py as a reusable dask_client fixture. Remove unused Client import from test_catalog.py, keeping only Future. https://claude.ai/code/session_013NNQnzZHryYqUC1eAWFC5w
Contributor
Author
|
I don't really understand the circumstances of these changes, they change the behavior of Catalog a lot. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dask_graph, dask_keys, dask_tokenize, dask_postcompute,
dask_postpersist, dask_optimize, and dask_scheduler methods to
HealpixDataset, delegating to the underlying _ddf NestedFrame.
This allows dask.distributed.Client.compute(catalog) to return a Future
instead of requiring users to access the internal _ddf attribute.
Fixes #1028
https://claude.ai/code/session_013NNQnzZHryYqUC1eAWFC5w