Fix reading/writing of sparse histogram #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #380 +/- ##
============================================
Coverage 94.09% 94.09%
============================================
Files 59 59
Lines 2166 2167 +1
============================================
+ Hits 2038 2039 +1
Misses 128 128 ☔ View full report in Codecov by Sentry. |
delucchi-cmu
approved these changes
Oct 16, 2024
camposandro
added a commit
that referenced
this pull request
Oct 22, 2024
* Bump pre-commit-ci/lite-action from 1.0.2 to 1.0.3 Bumps [pre-commit-ci/lite-action](https://github.com/pre-commit-ci/lite-action) from 1.0.2 to 1.0.3. - [Release notes](https://github.com/pre-commit-ci/lite-action/releases) - [Commits](pre-commit-ci/lite-action@v1.0.2...v1.0.3) --- updated-dependencies: - dependency-name: pre-commit-ci/lite-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update number of positional args * update healpixdataset catalog info type * run ci * Override catalog's `__len__` method (#371) * Wrap catalog's length method * Clarify error message * add alignment parameter to moc * Add sparse histogram implementation (#376) * Add sparse histogram implementation * Add scipy as a dependency * Improve test coverage * Fix read/write of dense histogram (#380) * Update missing hipscat references --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sean McGuire <[email protected]> Co-authored-by: Sean McGuire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #376 I introduced some incorrect changes to the I/O of SparseHistogram dense arrays and it caused unit tests to fail in hipscat-import. This fixes it.
Code Quality