Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit kwargs passed to file.open. #341

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Limit kwargs passed to file.open. #341

merged 1 commit into from
Sep 12, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Not all file open calls can handle so many pass-through kwargs, and there may be overlap with other kwargs passed to the pandas call. This attempts to split into different use cases.

Fixes CI failures in astronomy-commons/lsdb#413

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.00%. Comparing base (a5f7399) to head (b7d565d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #341   +/-   ##
=======================================
  Coverage   93.99%   94.00%           
=======================================
  Files          58       58           
  Lines        2115     2117    +2     
=======================================
+ Hits         1988     1990    +2     
  Misses        127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [a5f7399] After [048e42b] Ratio Benchmark (Parameter)
88.3±2ms 90.9±2ms 1.03 benchmarks.Suite.time_paths_creation
41.4±0.7ms 42.9±1ms 1.03 benchmarks.Suite.time_pixel_tree_creation
373±4ms 377±2ms 1.01 benchmarks.Suite.time_outer_pixel_alignment
76.0±0.9ms 75.8±0.3ms 1 benchmarks.MetadataSuite.time_load_partition_join_info
13.0±0.2ms 13.1±0.3ms 1 benchmarks.Suite.time_inner_pixel_alignment
968±3μs 969±7μs 1 benchmarks.time_test_cone_filter_multiple_order
19.5±0.2ms 19.3±0.4ms 0.99 benchmarks.MetadataSuite.time_load_partition_info_order6
76.7±0.8ms 75.8±0.4ms 0.99 benchmarks.MetadataSuite.time_load_partition_info_order7
114±0.5ms 113±0.4ms 0.99 benchmarks.time_test_alignment_even_sky

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu merged commit 23ae2ee into main Sep 12, 2024
12 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/kwargs branch September 12, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants