Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace FilePointer with universal pathlib #336

Merged
merged 9 commits into from
Sep 12, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Related to #320, #313, #307
Closes #79

Solution Description

Use fsspec's project, universal-pathlib as a path provider. In this way, everywhere we currently pass in a FilePointer we can use a Path instead, and when we need to create remote connections, use UPath.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Copy link

github-actions bot commented Aug 29, 2024

Before [2a7ea9e] After [185b668] Ratio Benchmark (Parameter)
86.7±2ms 89.1±2ms 1.03 benchmarks.Suite.time_paths_creation
374±3ms 382±8ms 1.02 benchmarks.Suite.time_outer_pixel_alignment
113±0.5ms 114±0.7ms 1.01 benchmarks.time_test_alignment_even_sky
76.6±0.7ms 76.7±0.5ms 1 benchmarks.MetadataSuite.time_load_partition_info_order7
19.9±0.5ms 19.7±0.4ms 0.99 benchmarks.MetadataSuite.time_load_partition_info_order6
76.9±0.7ms 76.1±0.2ms 0.99 benchmarks.MetadataSuite.time_load_partition_join_info
42.5±0.4ms 42.2±0.6ms 0.99 benchmarks.Suite.time_pixel_tree_creation
13.5±0.2ms 13.1±0.4ms 0.97 benchmarks.Suite.time_inner_pixel_alignment
995±20μs 966±4μs 0.97 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.99%. Comparing base (2a7ea9e) to head (57c8a41).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
- Coverage   94.04%   93.99%   -0.05%     
==========================================
  Files          58       58              
  Lines        2132     2115      -17     
==========================================
- Hits         2005     1988      -17     
  Misses        127      127              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked in details, but it looks great. I have an only question, should we allow something like str | Path | UPath for "very public" interfaces like read_from_hipscat?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add decorator to convert string to file pointer
3 participants