Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smoke test, uses pathlib #290

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Fix smoke test, uses pathlib #290

merged 1 commit into from
Jun 11, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Addresses smoke test failure.

There was an unfortunate merge combination with #289 and #288, where one uses os.path.join, and the other removes the import os statement. This updates to use pathlib for test path construction.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.69%. Comparing base (b829115) to head (578c46f).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   93.68%   93.69%   +0.01%     
==========================================
  Files          57       57              
  Lines        1979     1983       +4     
==========================================
+ Hits         1854     1858       +4     
  Misses        125      125              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [a7338ca] After [5f9c710] Ratio Benchmark (Parameter)
77.1±0.3ms 79.5±2ms 1.03 benchmarks.MetadataSuite.time_load_partition_info_order7
76.9±0.2ms 78.9±2ms 1.03 benchmarks.MetadataSuite.time_load_partition_join_info
123±0.8ms 126±0.4ms 1.02 benchmarks.time_test_alignment_even_sky
13.3±0.1ms 13.4±0.3ms 1.01 benchmarks.Suite.time_inner_pixel_alignment
362±2ms 365±1ms 1.01 benchmarks.Suite.time_outer_pixel_alignment
983±2μs 989±2μs 1.01 benchmarks.time_test_cone_filter_multiple_order
19.2±0.7ms 19.3±0.6ms 1 benchmarks.MetadataSuite.time_load_partition_info_order6
84.0±1ms 83.0±2ms 0.99 benchmarks.Suite.time_paths_creation
41.8±0.5ms 41.3±1ms 0.99 benchmarks.Suite.time_pixel_tree_creation

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu merged commit 7b37616 into main Jun 11, 2024
12 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/smoke/pathlib branch June 11, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants