Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fix for https protocol #212

Merged
merged 1 commit into from
Feb 13, 2024
Merged

add fix for https protocol #212

merged 1 commit into from
Feb 13, 2024

Conversation

dougbrn
Copy link
Contributor

@dougbrn dougbrn commented Feb 12, 2024

Change Description

This resolves #211. Ends up being a really simple fix to just not cut off the protocol in case of https. I hestitate to add a unit test for this, as it would depend on an externally hosted dataset, but if that's not a concern then I can add something.

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Copy link

Before [684cd83] After [fb79baa] Ratio Benchmark (Parameter)
637±3ms 653±6ms 1.03 benchmarks.Suite.time_pixel_tree_creation
80.2±0.5ms 80.8±0.5ms 1.01 benchmarks.MetadataSuite.time_load_partition_info_order7
80.3±0.5ms 81.3±0.9ms 1.01 benchmarks.MetadataSuite.time_load_partition_join_info
97.8±0.6ms 99.1±1ms 1.01 benchmarks.time_test_cone_filter_multiple_order
125±0.1ms 123±1ms 0.99 benchmarks.time_test_alignment_even_sky
20.6±0.08ms 20.1±0.7ms 0.98 benchmarks.MetadataSuite.time_load_partition_info_order6

Click here to view all benchmarks.

@dougbrn dougbrn merged commit 745f38b into main Feb 13, 2024
12 checks passed
@dougbrn dougbrn deleted the https_io branch February 13, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading a hipscat dataset from a web url fails
2 participants