Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSV file to partition info loading benchmark #206

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Loading a catalog's partition info will now predominantly occur with the partition_info.csv file. This adds that file in the benchmark generation, and tests that this method is faster.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10945ca) 100.00% compared to head (9135f3b) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #206   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        55           
  Lines         1923      1923           
=========================================
  Hits          1923      1923           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 7, 2024

Before [4e253a5] After [1c3c14d] Ratio Benchmark (Parameter)
19.0±0.05ms 19.2±0.05ms 1.01 benchmarks.MetadataSuite.time_load_partition_info_order6
78.6±0.5ms 79.2±0.4ms 1.01 benchmarks.MetadataSuite.time_load_partition_join_info
95.9±0.9ms 97.3±0.5ms 1.01 benchmarks.time_test_cone_filter_multiple_order
79.3±0.7ms 79.4±0.4ms 1 benchmarks.MetadataSuite.time_load_partition_info_order7
125±0.9ms 125±1ms 1 benchmarks.time_test_alignment_even_sky
644±4ms 635±2ms 0.99 benchmarks.Suite.time_pixel_tree_creation

Click here to view all benchmarks.

Copy link
Contributor

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@delucchi-cmu delucchi-cmu merged commit 316ff46 into main Feb 7, 2024
12 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/benchmark branch February 7, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants