-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement box filtering #202
Conversation
Click here to view all benchmarks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 54 55 +1
Lines 1848 1923 +75
=========================================
+ Hits 1848 1923 +75 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels and works great.
One note about performance: selecting large range, in any of ra
or dec
, for norder=10 takes around a minute on my machine. I believe it is the same order of magnitude as other actions on trillion-row scale catalogs, so maybe it is not a big issue for now.
I'd be interested in seeing where that time is. My guess would be creating the pixel trees for large areas at order 10. Not needed now, but I wonder if we convert our large order 10 area to a MOC if that would make it quicker by reducing the number of pixels in the tree. We could also improve the pixel tree performance ofc (or rewrite it in rust) but that might be more difficult. |
Implements box filtering for range of right ascension (ra) and/or declination (dec). If both are provided we construct a spherical polygon and use the preexisting polygon search. This feature allows to select the partitions of a subregion of the catalog sky, reducing the number of partition files read and therefore improving runtime performance.
Needed for astronomy-commons/lsdb#90.
Code Quality