Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kwargs for dataset read. #164

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Use kwargs for dataset read. #164

merged 1 commit into from
Nov 13, 2023

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Closes #161 by adding kwargs to parquet dataset read, and using the appropriate arguments in our method that creates new dataset parquet files.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #164 (35fa8aa) into main (8a22c03) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #164   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         1527      1527           
=========================================
  Hits          1527      1527           
Files Coverage Δ
src/hipscat/io/file_io/file_io.py 100.00% <100.00%> (ø)
src/hipscat/io/write_metadata.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

Before [8a22c03] After [ce6e397] Ratio Benchmark (Parameter)
96.7±2ms 96.3±0.9ms 1 benchmarks.time_test_cone_filter_multiple_order
654±4ms 648±7ms 0.99 benchmarks.Suite.time_pixel_tree_creation
117±0.9ms 115±0.5ms 0.98 benchmarks.time_test_alignment_even_sky

Click here to view all benchmarks.

Copy link

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice.

@delucchi-cmu delucchi-cmu merged commit 9b53aeb into main Nov 13, 2023
12 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/161/kwargs branch November 13, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make read_parquet_dataset() less I/O intense
2 participants