Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require full catalog to plot pixel list #159

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Closes #157 and partially addresses #156.

Solution Description

Give an explicit error when attempting to visualize a non-on-disk catalog, since no fits points file will be present. Support showing the pixel map for a list of HealpixPixel, outside of a constructed catalog.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #159 (80ca21e) into main (8340e73) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #159   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         1522      1527    +5     
=========================================
+ Hits          1522      1527    +5     
Files Coverage Δ
src/hipscat/inspection/__init__.py 100.00% <100.00%> (ø)
src/hipscat/inspection/visualize_catalog.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

github-actions bot commented Nov 2, 2023

Before After Ratio Method
[8340e73] [febf68e]
197±6ms 221±10ms 1.12 benchmarks.time_test_alignment_even_sky
149±4ms 159±5ms 1.07 benchmarks.time_test_cone_filter_multiple_order
977±30ms 1.04±0.04s 1.07 benchmarks.Suite.time_pixel_tree_creation

Click here to view all benchmarks.

Copy link

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@delucchi-cmu delucchi-cmu merged commit 2ea3300 into main Nov 2, 2023
12 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/157/viz branch November 2, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add visualization method calls for in-memory catalog representation
2 participants