Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fancier typing on the storage_options #155

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

For lsdb, we're checking types with mypy, and storage_options should use a nullable type declaration.

@github-actions
Copy link

Before After Ratio Method
[e6ac8e2] [64a065e]
1.02±0.01s 1.02±0s 0.99 benchmarks.Suite.time_pixel_tree_creation
218±8ms 213±2ms 0.97 benchmarks.time_test_alignment_even_sky
162±10ms 152±1ms 0.94 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #155 (7201d25) into main (e6ac8e2) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #155   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         1518      1522    +4     
=========================================
+ Hits          1518      1522    +4     
Files Coverage Δ
...catalog/association_catalog/association_catalog.py 100.00% <100.00%> (ø)
...catalog/association_catalog/partition_join_info.py 100.00% <100.00%> (ø)
src/hipscat/catalog/catalog.py 100.00% <100.00%> (ø)
src/hipscat/catalog/dataset/base_catalog_info.py 100.00% <100.00%> (ø)
...rc/hipscat/catalog/dataset/catalog_info_factory.py 100.00% <100.00%> (ø)
src/hipscat/catalog/dataset/dataset.py 100.00% <100.00%> (ø)
...hipscat/catalog/healpix_dataset/healpix_dataset.py 100.00% <100.00%> (ø)
src/hipscat/catalog/partition_info.py 100.00% <100.00%> (ø)
src/hipscat/inspection/almanac.py 100.00% <100.00%> (ø)
src/hipscat/inspection/almanac_info.py 100.00% <100.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

Before After Ratio Method
[e6ac8e2] [d362a4c]
177±0.6ms 181±4ms 1.02 benchmarks.time_test_alignment_even_sky
865±4ms 865±9ms 1 benchmarks.Suite.time_pixel_tree_creation
131±0.7ms 130±2ms 1 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

@github-actions
Copy link

Before After Ratio Method
[e6ac8e2] [39d36cc]
209±3ms 220±5ms 1.06 benchmarks.time_test_alignment_even_sky
157±2ms 162±4ms 1.03 benchmarks.time_test_cone_filter_multiple_order
1.07±0.01s 1.10±0.04s 1.03 benchmarks.Suite.time_pixel_tree_creation

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu merged commit 3bd039f into main Oct 25, 2023
12 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/storage_type branch October 31, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants