Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get_pixels method #151

Merged
merged 7 commits into from
Oct 24, 2023
Merged

Remove get_pixels method #151

merged 7 commits into from
Oct 24, 2023

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Closes #142

Removes the Catalog.get_pixels method, and stores the partition info only as a list of healpix pixels, instead of as pandas dataframe.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #151 (2560ed8) into main (377b9ed) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #151   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         1535      1518   -17     
=========================================
- Hits          1535      1518   -17     
Files Coverage Δ
src/hipscat/catalog/catalog.py 100.00% <ø> (ø)
...hipscat/catalog/healpix_dataset/healpix_dataset.py 100.00% <100.00%> (ø)
src/hipscat/catalog/partition_info.py 100.00% <100.00%> (ø)
src/hipscat/pixel_math/cone_filter.py 100.00% <100.00%> (ø)
src/hipscat/pixel_tree/pixel_tree_builder.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

Before After Ratio Method
[3c40234] [38a3a0e]
failed failed n/a benchmarks.time_test_cone_filter_multiple_order
857±4ms 860±4ms 1.00 benchmarks.Suite.time_pixel_tree_creation
176±0.5ms 176±0.2ms 1.00 benchmarks.time_test_alignment_even_sky

Click here to view all benchmarks.

@github-actions
Copy link

Before After Ratio Method
[3c40234] [53127dc]
1.02±0s 1.01±0s 1 benchmarks.Suite.time_pixel_tree_creation
214±1ms 212±0.3ms 0.99 benchmarks.time_test_alignment_even_sky
161±1ms 153±0.6ms 0.95 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

@github-actions
Copy link

Before After Ratio Method
[3c40234] [04900f2]
176±0.1ms 177±0.6ms 1 benchmarks.time_test_alignment_even_sky
867±3ms 859±6ms 0.99 benchmarks.Suite.time_pixel_tree_creation
138±1ms 130±1ms 0.94 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

@github-actions
Copy link

Before After Ratio Method
[3c40234] [ad2fddb]
1.09±0.01s 1.11±0.02s 1.02 benchmarks.Suite.time_pixel_tree_creation
212±6ms 208±4ms 0.98 benchmarks.time_test_alignment_even_sky
172±2ms 160±3ms 0.93 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

@github-actions
Copy link

Before After Ratio Method
[3c40234] [482d6d3]
153±0.3ms 153±0.8ms 1 benchmarks.time_test_alignment_even_sky
844±20ms 833±3ms 0.99 benchmarks.Suite.time_pixel_tree_creation
133±1ms 125±0.8ms 0.94 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

@github-actions
Copy link

Before After Ratio Method
[7a1e727] [d100c60]
176±0.2ms 177±0.2ms 1.01 benchmarks.time_test_alignment_even_sky
863±2ms 861±4ms 1 benchmarks.Suite.time_pixel_tree_creation
136±1ms 129±0.5ms 0.95 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu merged commit e6ac8e2 into main Oct 24, 2023
12 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/142/get_healpix_pixels branch October 31, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PartitionInfo structure and get_pixels vs get_healpix_pixels
2 participants