remove logically unreachable lines to get 100 percent coverage

[maxwest-uw]

Change Description

while waiting on some other PRs, I decided to address something that's been bothering me... the hipscat unit tests are off from 100 percent coverage by two lines 😭 however, when I tried writing a test that would cover this, I realized that the lines in question are unreachable, as a child node cannot be created before a parent node, meaning that a user can never pass a list of children nodes into the init of a parent node. I went ahead and removed the code so that we can have full coverage

Solution Description

removed unreachable lines.

Code Quality

• I have read the Contribution Guide
• My code follows the code style of this project
• My code builds (or compiles) cleanly without any errors or warnings
• My code contains relevant comments and necessary documentation

[codecov]

Codecov Report

Merging #116 (d532af9) into main (20261fd) will increase coverage by 0.14%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main      #116      +/-   ##
===========================================
+ Coverage   99.85%   100.00%   +0.14%     
===========================================
  Files          45        45              
  Lines        1410      1407       -3     
===========================================
- Hits         1408      1407       -1     
+ Misses          2         0       -2     

Files Changed	Coverage Δ
src/hipscat/pixel_tree/pixel_node.py	100.00% <ø> (+3.57%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[smcguire-cmu]

Thank you! I've been meaning to remove this, you're right that some changes were made to the logic which makes this unreachable.