Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups. #115

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Cleanups. #115

merged 3 commits into from
Jul 20, 2023

Conversation

delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented Jul 20, 2023

Change Description

While implementing SOAP (source-object-association-pipeline), I came across some affiliated cleanups.

  • Uses the Healpix API for visualize catalog method, to simplify code experience
  • Conversion for PixelAlignment dataframe to integer types
  • black formatting
  • fixed warnings when rendering RTD bulleted lists

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #115 (6fca3cf) into main (6125aa8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   99.85%   99.85%   -0.01%     
==========================================
  Files          45       45              
  Lines        1412     1410       -2     
==========================================
- Hits         1410     1408       -2     
  Misses          2        2              
Impacted Files Coverage Δ
src/hipscat/pixel_tree/pixel_tree.py 100.00% <ø> (ø)
...catalog/association_catalog/association_catalog.py 100.00% <100.00%> (ø)
src/hipscat/inspection/visualize_catalog.py 100.00% <100.00%> (ø)
src/hipscat/pixel_math/healpix_pixel.py 100.00% <100.00%> (ø)
src/hipscat/pixel_tree/pixel_alignment.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@delucchi-cmu delucchi-cmu merged commit 20261fd into main Jul 20, 2023
10 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/refactor branch August 7, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants