Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cone Search Catalog Filter #113

Merged
merged 4 commits into from
Jul 17, 2023
Merged

Add Cone Search Catalog Filter #113

merged 4 commits into from
Jul 17, 2023

Conversation

smcguire-cmu
Copy link
Contributor

@smcguire-cmu smcguire-cmu commented Jul 14, 2023

Change Description

Adds the filter_by_cone method to the Catalog class, which generates a new Catalog object with only pixels that overlap with a specified cone.

Fills out the TODO in the cone_search demo notebook.

closes #7

  • My PR includes a link to the issue that I am addressing

Solution Description

Generates the pixels of the cone at the highest order in the catalog using healpy, forms a tree from the cone pixels and performs an inner catalog alignment against the pixel tree of the catalog. The aligned pixels are used to generate the new filtered catalog.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #113 (05d1cd4) into main (550021f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          44       45    +1     
  Lines        1382     1412   +30     
=======================================
+ Hits         1380     1410   +30     
  Misses          2        2           
Impacted Files Coverage Δ
...catalog/association_catalog/association_catalog.py 100.00% <100.00%> (ø)
src/hipscat/catalog/catalog.py 100.00% <100.00%> (ø)
src/hipscat/pixel_math/cone_filter.py 100.00% <100.00%> (ø)
src/hipscat/pixel_tree/pixel_alignment.py 100.00% <100.00%> (ø)
src/hipscat/pixel_tree/pixel_tree.py 100.00% <100.00%> (ø)
src/hipscat/pixel_tree/pixel_tree_builder.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@smcguire-cmu smcguire-cmu changed the title Sean/cone search Add Cone Search Catalog Filter Jul 14, 2023
Copy link
Contributor

@delucchi-cmu delucchi-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@smcguire-cmu smcguire-cmu merged commit 6125aa8 into main Jul 17, 2023
10 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/cone-search branch July 17, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cone search and pixel filter functionality
2 participants