Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatched destination pixel map behavior #112

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Under some conditions, the destination pixel map produced by compute_pixel_map has different destination pixels than that produced by generate_destination_pixel_map, using a pre-defined alignment array. In this situation, the alignment and the pixel map will not agree on the correct pixels.

This manifested in the hipscat-import catalog creation splitting inputs according to the alignment, and trying to reduce them according to the destination pixel map, and not finding the appropriate files.

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #112 (6796913) into main (293a76d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files          41       41           
  Lines        1181     1181           
=======================================
  Hits         1179     1179           
  Misses          2        2           
Impacted Files Coverage Δ
src/hipscat/pixel_math/partition_stats.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@delucchi-cmu delucchi-cmu merged commit eb3a3db into main Jul 12, 2023
10 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/math branch July 19, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants