-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Catalog Alignment class and functions #110
Conversation
# Conflicts: # src/hipscat/catalog/__init__.py # src/hipscat/catalog/association_catalog/__init__.py # src/hipscat/catalog/association_catalog/association_catalog.py # src/hipscat/pixel_tree/pixel_tree.py # src/hipscat/pixel_tree/pixel_tree_builder.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through the design document and it clarified some of my questions. Thanks!
Co-authored-by: Melissa DeLucchi <[email protected]>
Co-authored-by: Melissa DeLucchi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 99.83% 99.85% +0.02%
==========================================
Files 41 44 +3
Lines 1181 1382 +201
==========================================
+ Hits 1179 1380 +201
Misses 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good. The new comments make it easier to follow and the tests have good cases.
I added one suggestion to the tests.
Change Description
Creates the
CatalogAlignment
class to represent the alignment between catalogs. This includes a table with the pixel-to-pixel mapping between the files in each catalog, and the resulting tree from selecting the highest level of partitioning in each branch.Adds functions to compute the alignment between catalogs. This includes adding functionality to the
PixelTreeBuilder
class.resolves #9
Solution Description
The algorithm to perform the catalog alignment is described in detail in this design document
Code Quality
New Feature Checklist