Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text wrap issue with runtime spinner #1779

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix text wrap issue with runtime spinner #1779

wants to merge 2 commits into from

Conversation

pritt20
Copy link
Contributor

@pritt20 pritt20 commented Jan 6, 2025

Description

We observed that runtime init long text messages cause the spinner to print on multiple lines repeatedly. This is usually caused due to small terminal window size.

Screenshot:

image

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

Tested the change locally and could see that spinner text appears to be fine on smaller terminal window:

image

image

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@schnie
Copy link
Member

schnie commented Jan 6, 2025

@pritt20 I still see the issue if I shrink my terminal down smaller than the first line. I wonder how hard it would be to somehow hook into the terminal size and wrap the text to multiple lines accordingly. Or maybe cut off the line and end with ... or something.

@pritt20
Copy link
Contributor Author

pritt20 commented Jan 7, 2025

@pritt20 I still see the issue if I shrink my terminal down smaller than the first line. I wonder how hard it would be to somehow hook into the terminal size and wrap the text to multiple lines accordingly. Or maybe cut off the line and end with ... or something.

Thanks @schnie ! Yeah, I am able to reproduce it as well. I'll try other options to see if we can include terminal size dynamically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants