This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Add append and replace load strategies with example DAG for Table #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunank200
requested review from
utkarsharma2,
rajaths010494,
phanikumv,
tatiana,
pankajastro and
pankajkoti
as code owners
|
|
|
Can we add test cases to validate the behavior?
|
phanikumv
reviewed
Mar 30, 2023
Added the tests: 9d9f5e8 |
utkarsharma2
approved these changes
Mar 31, 2023
tests_integration/test_data_provider/test_databases/test_base.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Phani Kumar <[email protected]>
Co-authored-by: Phani Kumar <[email protected]>
Co-authored-by: Phani Kumar <[email protected]>
Co-authored-by: Utkarsh Sharma <[email protected]>
sunank200
force-pushed
the
append-and-replace
branch
from
fea7f59 to
57f3527
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
Although the logic for the replace and append is implemented this is not working because if_exists is not propagated from TransferParams here: https://github.com/astronomer/apache-airflow-provider-transfers/blob/main/src/universal_transfer_operator/data_providers/database/base.py#L202
closes: #47
What is the new behavior?
Does this introduce a breaking change?
No
Checklist