Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Interned visibility constraints #15079

Draft
wants to merge 65 commits into
base: main
Choose a base branch
from
Draft

[red-knot] Interned visibility constraints #15079

wants to merge 65 commits into from
+2,994 −753

Conversation

sharkdp
Copy link
Contributor

@sharkdp sharkdp commented Dec 20, 2024

Summary

Unfinished experiment to intern VisibilityConstraint using salsa. Still >150 lifetime errors to go.

sharkdp added 30 commits December 20, 2024 09:18
@sharkdp
[red-knot] Statically known branches
e8cfb34
@sharkdp
Temporarily patch typeshed to avoid cycles
34be5b6
@sharkdp
Another patch to fix the sys.version_info tests
7b79a56
@sharkdp
Fix string annotation tests
2042c68
@sharkdp
Reset symbol states after if-elif-else chains
76e277b
@sharkdp
Add support for sys.platform
3d85c7d
@sharkdp
Add tests for common use cases
dc9fbaa
@sharkdp
Fix match control flow
c28bcdb
@sharkdp
Fix match control flow
2b12c49
@sharkdp
Fix boolean expression tests
e871ea1
@sharkdp
Clippy suggestions
00e698b
@sharkdp
Update snapshots
27b64a0
@sharkdp
Fix serde feature compilation problem
a37dac1
@sharkdp
Add recursion limit hack
e044fde
@sharkdp
Short circuit, increase threshold
90e639b
@sharkdp
Renamings
3a1dbc1
@sharkdp
Introduce VisibilityConstraints struct
4f6fba2
@sharkdp
Minor cleanup
5df51f2
@sharkdp
Refactoring
79b582c
@sharkdp
Rename
afe1572
@sharkdp
Further cleanup
853e171
@sharkdp
Rename, comment
2e6f757
@sharkdp
Refactor
8a93a9a
@sharkdp
Reactivate symbol_state tests
12f139d
@sharkdp
sys.platform documentation
9a1d1ea
@sharkdp
Clippy
81bfc52
@sharkdp
Fix fuzz build
189f2ef
@sharkdp
Extend sys.platform tests
c1748f0
@sharkdp
Implement if-expressions
d249801
@sharkdp
Fix boolean expressions
8b60946
sharkdp added 25 commits December 20, 2024 09:18
@sharkdp
Simplify iterators
167337b
@sharkdp
scope_start_visibility
91fa462
@sharkdp
Rename to simplify_visibility_constraints
b37f095
@sharkdp
Fix comment
090563e
@sharkdp
Update comment
47bb571
@sharkdp
Handle ambiguous visibility, fix while-loop inference
c9eb782
@sharkdp
Clippy
22e345a
@sharkdp
Fix tests after rebase
a4d805f
@sharkdp
Remove _iter suffix
f9f4615
@sharkdp
Store Expression<'db> inside VisibilityConstraint
4353730
@sharkdp
Use iterators instead of vec
402f279
@sharkdp
Short circuit if declared type is available
c0e7c08
@sharkdp
Always build a union of inferred_ty and declared_ty
89fefe0
@sharkdp
Raise diagnostic for possibly-undeclared symbols
0b70c1c
@sharkdp
Add section for yet-unsupported features
2c104c6
@sharkdp
Simplify code in simplify_visibility_constraints
025804e
@sharkdp
Use actual return values in dummy functions
2dfe682
@sharkdp
Use struct instead of three-tuple
3dde382
@sharkdp
::default() instead of ::new()
df35369
@sharkdp
Minor review comments
0381885
@sharkdp
Use KnownModule
0d6425a
@sharkdp
Minor iterator changes
b85a56d
@sharkdp
More minor changes
f0e9cce
@sharkdp
Revert possibly-unbound changes
fafecc9
@sharkdp
Interned visibility constraints
b0986de
@sharkdp sharkdp added the red-knot Multi-file analysis & type inference label Dec 20, 2024
@sharkdp sharkdp changed the title Interned visibility constraints [red-knot] Interned visibility constraints Dec 20, 2024
@sharkdp sharkdp mentioned this pull request Dec 20, 2024
Merged
@sharkdp sharkdp force-pushed the david/statically-known-branches-2 branch from b3434b2 to 95d079c Compare December 21, 2024 10:26
Base automatically changed from david/statically-known-branches-2 to main December 21, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm Awaiting requested review from carljm carljm will be requested when the pull request is marked ready for review carljm is a code owner

@MichaReiser MichaReiser Awaiting requested review from MichaReiser MichaReiser will be requested when the pull request is marked ready for review MichaReiser is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood will be requested when the pull request is marked ready for review AlexWaygood is a code owner

Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sharkdp