Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chatpal: Enable custom search parameters #601

Closed

Conversation

Peym4n
Copy link

@Peym4n Peym4n commented Apr 4, 2019

RC issue: RocketChat#13828
I had to create a separate PR for assistify, because the package structure differs compared to the current RC.
Required for:
redlink-gmbh/smarti#278
redlink-gmbh/smarti#288

@mrsimpson
Copy link
Member

mrsimpson commented Apr 4, 2019

@peyman is this compatible with the current version? Meaning: Can we implement this PR while keepig the old Chatpal?
It absolutely looks like that (codewise), just wanted to re-assure that Chatpal does not e. g. validate the parameters submitted

@Peym4n
Copy link
Author

Peym4n commented Apr 4, 2019

@mrsimpson Yes, this is compatible with the current Chatpal version on assistify's RC.

@mrsimpson mrsimpson self-requested a review April 4, 2019 14:50
Copy link
Member

@mrsimpson mrsimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks un-dangerous to me.

@mrsimpson
Copy link
Member

included in th core as of now

@mrsimpson mrsimpson closed this Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants