Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Support tokio::process::command. #223

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nickpdemarco
Copy link

After hitting this issue I tried to add basic support for tokio::process::command. It requires a new trait, AsyncOutputAssertExt in order to get the following to compile:

    tokio::process::Command::cargo_bin("my-bin")
        .expect("")
        .assert()
        .await
        .success();

I have not yet done the due diligence to confirm this covers all reasonable use cases. Raising this PR for visibility and to ask for some guidance on how to get this production-ready. Documentation TODO.

@nickpdemarco nickpdemarco marked this pull request as draft November 12, 2024 22:51
@epage
Copy link
Contributor

epage commented Nov 13, 2024

According to our contributor guide

Already have an idea? It might be good to first create an issue to propose it so we can make sure we are aligned and lower the risk of having to re-work some of it and the discouragement that goes along with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants