-
Notifications
You must be signed in to change notification settings - Fork 52
Solution: Victor Hugo Gomez #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hugo05Duran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job.
| // page: 1, | ||
| // paginationInfo: null, | ||
| // episodes: [], | ||
| // hasLoaded: false, | ||
| // hasError: false, | ||
| // errorMessage: null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comments are necesary and must to delete it.
| if (prevPage !== page) { | ||
| this.loadEpisodes(page); | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well thought out and executed.
src/pages/Home/Home.js
Outdated
| } | ||
|
|
||
| async loadEpisodes(page) { | ||
| console.log(this); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to delete all console log to avoid some messages in the dev tools.
| return ( | ||
| <Layout> | ||
| <section className="row"> | ||
| {/* {hasLoaded && !hasError && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detele comments.
| <div className="col col-12"> | ||
| <h1>Episodes loaded!</h1> | ||
| </div> | ||
| )} */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detele comments.
| <div className="col col-12"> | ||
| <hr /> | ||
| </div> | ||
| {/* {episodes.map((episode) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detele comments.
| airDate={episode.air_date} | ||
| episode={episode.episode} | ||
| /> | ||
| ))} */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detele comments.
No description provided.