-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BackupService: new option to delete Fuseki backups after copy #1313
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Looking forward to the stability improvements :)
@@ -147,7 +164,7 @@ const BackupService = { | |||
} | |||
} | |||
}, | |||
/** Returns an array of file paths to the backups relative to `this.settings.localServer.fusekiBase`. */ | |||
// Returns an array of file paths to the backups relative to `this.settings.localServer.fusekiBase`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, why the change from jsdoc to normal comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry. I learnt that for, one-line comments, it's better to use //
than /* */
, as there is less risks of forgetting the closing */
, which can break other comments... What advantage is there to have jsdoc comments in that case ?
New
deleteFusekiBackupsAfterCopy
setting