Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address build warnings from .NET 8 analyzers #764

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Address build warnings from .NET 8 analyzers #764

wants to merge 1 commit into from

Conversation

jimmylewis
Copy link
Contributor

  • Mostly CA1307 to specify a StringComparison on string operations. Most of these were fixed with conditional compilation, but I suppressed a couple where it wouldn't matter (non-cased characters) and the code would have been ugly to use conditional compilation.
  • Some HashCode implementations were changed from XOR of two values to using HashCode.Combine instead for .NET 8.

@jimmylewis
Address build warnings from .NET 8 analyzers
414ce5a 
- Mostly CA1307 to specify a StringComparison on string operations.  Most of these were fixed with conditional compilation, but I suppressed a couple where it wouldn't matter (non-cased characters) and the code would have been ugly to use conditional compilation.
- Some HashCode implementations were changed from XOR of two values to using HashCode.Combine instead for .NET 8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jimmylewis