Updating Playground-ready from main #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Signed-off-by: Namith Jawahar <[email protected]>
* Update blueprint.json Switching to default theme of 2022 to support minimum WP Playground support for WordPress version as 5.9.9 Signed-off-by: Namith Jawahar <[email protected]> * Switching blueprint.json to 2022 theme Signed-off-by: Alex Sirota <[email protected]> --------- Signed-off-by: Alex Sirota <[email protected]> Signed-off-by: Namith Jawahar <[email protected]>
…rite is enabled. (#80) * Add class for overriding plugins screens. * Remove unused tabs when API rewrite is enabled.
…abled. (#82) * Add class for overriding themes screens. * Hide unsupported filters. * Redirect unsupported filters to `theme-install.php`. --------- Signed-off-by: Alex Sirota <[email protected]> Co-authored-by: Alex Sirota <[email protected]>
* Add PHPUnit scaffolding. * Add Composer files for dependencies and test script. * Add `.gitignore`. * Add sample test for `Admin_Settings::get_setting()`. * Add PHP 8.3 to the test matrix. * Add `.cache/*` to `.gitignore`. * Limit testing to PHP 7.4 (minimum) and 8.3 (latest).
* Fix PHP version. * Add `push` and `workflow_dispatch` workflow triggers.
* Introduce a test constant. * Don't initialize when the tests are running. * Use a new object for testing `Admin_Settings::get_setting()`.
|
I closed the previous PR and opened this one and resolved conflict in VS code using merge editor there, please review PR so I can update playground-ready branch with latest changes. |
chuckadams
approved these changes
Nov 2, 2024
|
Alas, as I don't have write access to the repo, my review approval doesn't unlock any merge to a protected main branch. 🤷 |
|
Yeah there's a resolve conflict that's in one file and I have to do it on command line and resolve in merge code editor. |
* Add French translations. * load any available translations with code in the plugin
Signed-off-by: Colin Stewart <[email protected]>
* added German translation * added gitignore for .DS_Store Signed-off-by: Harikrishnan R <[email protected]>
The Voltron has landed. See if you can find where.
…#118) * `Admin Settings`: Add multisite-safe deletion of all settings. * Delete all settings when the plugin is uninstalled.
Fixed typo in code deleted when addressing #102
* create zip with each new tagged release * update .gitattributes
Signed-off-by: Alex Sirota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What changed?
added PHP unit tests, fixed a bug
Why did it change?
because new PHP unit tests have been added
Did you fix any specific issues?
#88
CERTIFICATION
By opening this pull request, I do agree to abide by
the CODE OF CONDUCT and be bound by the terms
of the Contribution Guidelines in effect on the date and time
of my contribution as proven by the
revision information in GitHub. I also agree that any previous contributions shall be deemed subject to the terms of the
version in effect on the date and time of this pull request, or any future revisions for pull requests I may submit.
Further, I certify that this work is my own, is original, does not violate the intellectual property of any other person
or entity, and I am not violating any license agreements or contracts I have with any person or entity. Finally, I agree
that this code may be licensed under any license deemed appropraite by AspirePress, including but not
limited to open source, closed source, proprietary or custom licenses, and that such license terms neither violate my
rights or my copyright to this code.