-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to create new branch and PR for generating POT automatically #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afragen
added
enhancement
New feature or request
i18n
Internationalization & Localization
labels
Dec 10, 2024
as remote branch created if it didn't previously exist
costdev
requested changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Andy, just a couple of suggestions and a question.
Co-authored-by: Colin Stewart <[email protected]> Signed-off-by: Andy Fragen <[email protected]>
Co-authored-by: Colin Stewart <[email protected]> Signed-off-by: Andy Fragen <[email protected]>
Remove comment spacer Signed-off-by: Andy Fragen <[email protected]>
costdev
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Removed Generate POT GA and replaced with workflow to create a new branch and then create a PR from that branch to
main
for the updated POT file.New workflow.
Why did it change?
Changed due to branch protection and GitHub Action not working.
Fixes #211
Did you fix any specific issues?
Now automatically creates a PR with updated POT on push to
main
CERTIFICATION
By opening this pull request, I do agree to abide by the Code of Conduct and be bound by the terms of the Contribution Guidelines in effect on the date and time of my contribution as proven by the revision information in GitHub.