Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to create new branch and PR for generating POT automatically #242

Merged
merged 10 commits into from
Dec 13, 2024

Conversation

afragen
Copy link
Contributor

@afragen afragen commented Dec 10, 2024

Pull Request

Removed Generate POT GA and replaced with workflow to create a new branch and then create a PR from that branch to main for the updated POT file.

New workflow.

Why did it change?

Changed due to branch protection and GitHub Action not working.
Fixes #211

Did you fix any specific issues?

Now automatically creates a PR with updated POT on push to main

CERTIFICATION

By opening this pull request, I do agree to abide by the Code of Conduct and be bound by the terms of the Contribution Guidelines in effect on the date and time of my contribution as proven by the revision information in GitHub.

@afragen afragen marked this pull request as ready for review December 10, 2024 21:44
@afragen afragen requested review from asirota and costdev December 10, 2024 21:44
@afragen afragen self-assigned this Dec 10, 2024
@afragen afragen added enhancement New feature or request i18n Internationalization & Localization labels Dec 10, 2024
as remote branch created if it didn't previously exist
Copy link
Contributor

@costdev costdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andy, just a couple of suggestions and a question.

.github/workflows/generate-pot-pr.yml Outdated Show resolved Hide resolved
.github/workflows/generate-pot-pr.yml Outdated Show resolved Hide resolved
.github/workflows/generate-pot-pr.yml Outdated Show resolved Hide resolved
afragen and others added 3 commits December 11, 2024 06:25
Co-authored-by: Colin Stewart <[email protected]>
Signed-off-by: Andy Fragen <[email protected]>
Co-authored-by: Colin Stewart <[email protected]>
Signed-off-by: Andy Fragen <[email protected]>
Remove comment spacer

Signed-off-by: Andy Fragen <[email protected]>
@costdev costdev merged commit ef25893 into aspirepress:main Dec 13, 2024
5 checks passed
@afragen afragen deleted the branch-pr branch December 13, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request i18n Internationalization & Localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Generate POT file GH action fails due to lack of rights to merge on main branch
2 participants