Add branded notices to inform users when AspireUpdate is in operation on a screen.

[costdev]

Pull Request

What changed?

1. A new class, AspireUpdate\Branding, has been introduced which will output an admin notice on certain screens when AP_ENABLE is true and AP_REMOVE_UI is undefined or false.
   • Dashboard > Updates
   • Plugins > Installed plugins
   • Plugins > Add New Plugin
   • Appearance > Themes
   • Appearance > Themes > Add New Theme
2. Styles have been added for .aspireupdate-notice.
   • Example: <div class="notice aspireupdate-notice"><p>I am a notice</p></div>
3. Tests have been added for AspireUpdate\Branding.

Dashboard > Updates

Plugins > Installed plugins

Plugins > Add New Plugin

Appearance > Themes

Appearance > Themes > Add New Theme

Line/Branch Coverage

Why did it change?

To inform users when AspireUpdate is in operation on these screens.

Did you fix any specific issues?

Fixes #72

CERTIFICATION

By opening this pull request, I do agree to abide by
the CODE OF CONDUCT and be bound by the terms
of the Contribution Guidelines in effect on the date and time
of my contribution as proven by the
revision information in GitHub. I also agree that any previous contributions shall be deemed subject to the terms of the
version in effect on the date and time of this pull request, or any future revisions for pull requests I may submit.
Further, I certify that this work is my own, is original, does not violate the intellectual property of any other person
or entity, and I am not violating any license agreements or contracts I have with any person or entity. Finally, I agree
that this code may be licensed under any license deemed appropraite by AspirePress, including but not
limited to open source, closed source, proprietary or custom licenses, and that such license terms neither violate my
rights or my copyright to this code.

[ipajen]

Don’t forget the to add the flag to the docs https://github.com/aspirepress/AspireUpdate/blob/main/README.md

So it should not be possible to set in the GUi to close branding? Is it possible close the notice ? (Can’t see in the picture)

[asirota]

This is a brand so it will not have a close link or ui control. Then config parameter can be used to turn it off.

[ipajen]

This is a brand so it will not have a close link or ui control. Then config parameter can be used to turn it off.

understand, but why do we want to offer it from a config parameter to turn it off but not in GUI?

[asirota]

We should eliminate the config parameter? Branding is not something you can easily remove. It's not a notice.

[costdev]

It's not a notice.

That raises the question of whether an admin notice is a suitable approach.

We could, for example, simply remove the notice wrapper and show this:

Or still use the notice area, but style it differently, like:

[namithj]

1. We should remove the new config parameter and connect this to the AP_NO_UI config parameter.

2. Lets get rid of that inline svg and move it to CSS.

[namithj]

It's not a notice.

That raises the question of whether an admin notice is a suitable approach.

We could, for example, simply remove the notice wrapper and show this:

Or still use the notice area, but style it differently, like:

I like the second option.

[namithj]

1. We should remove the new config parameter and connect this to the AP_NO_UI config parameter.

2. Lets get rid of that inline svg and move it to CSS.

[costdev]

@namithj PR has been updated.

1. Uses AP_REMOVE_UI instead of AP_REMOVE_BRANDING.
2. AP_REMOVE_BRANDING has been removed.
3. CSS is used for the SVG rather than file_get_contents(). - Nicely spotted on this one!

New screenshots are in the description.

[asirota]

There are new strings that will need to be updated. Can you the .pot file?

[costdev]

@asirota Done in 76998d4.

[ipajen]

Maybe worth updating docs to include branding as it’s not only settings anymore

today:
Disables plugin settings user interface, defaults to config parameters set in wp-config.php

[costdev]

@ipajen Done in e5c4335.

[namithj]

Do we need to translate the URLs?