Resolve PCP security warnings in `AspireUpdate\Admin_Settings::update…

…_settings()`. (#134)
aspirepress · Nov 5, 2024 · 1529cfb · 1529cfb
1 parent 2b15a47
commit 1529cfb
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/includes/class-admin-settings.php b/includes/class-admin-settings.php
@@ -239,8 +239,12 @@ public function update_settings() {
 		}
 
 		// Save settings and redirect.
-		if ( ( isset( $_POST['option_page'] ) && 'aspireupdate_settings' === $_POST['option_page'] ) ) {
-			update_site_option( $this->option_name, $this->sanitize_settings( wp_unslash( $_POST['aspireupdate_settings'] ) ) );
+		if ( ( isset( $_POST['option_page'], $_POST['aspireupdate_settings'] ) && 'aspireupdate_settings' === $_POST['option_page'] ) ) {
+			update_site_option(
+				$this->option_name,
+				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized -- Contents are sanitized in Admin_Settings::sanitize_settings.
+				$this->sanitize_settings( wp_unslash( $_POST['aspireupdate_settings'] ) )
+			);
 
 			wp_safe_redirect(
 				add_query_arg( [ network_admin_url( 'index.php?page=aspireupdate-settings' ) ] )