Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some questionable TypeScript code changes #343

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

alexeagle
Copy link
Member

Demonstrate Marvin checking TypeScript

Copy link

aspect-workflows bot commented Aug 28, 2024

Test

All tests were cache hits

22 tests (100.0%) were fully cached saving 5s.


Lint

2 issues require fixes
1 issues can be fixed automatically

💡 Reproduce linting failures with:

bazel lint //logger/frontend:compile_typings

💡 Auto-fix linting errors with:

bazel lint //logger/frontend:compile_typings --fix

@@ -40,7 +40,12 @@
}

private displayServerLogs(data: Response) {
console.log('in display');
const logMessage: string = 'in display';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint provided a suggestion

Suggested change
const logMessage: string = 'in display';
const logMessage = 'in display';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant