Skip to content

chore: add explicit access modifiers to methods in Angular4PaystackEmbedComponent #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

chore: add explicit access modifiers to methods in Angular4PaystackEmbedComponent #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions projects/angular4-paystack/src/lib/angular4-paystack-embed.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export class Angular4PaystackEmbedComponent implements OnInit {

constructor(private paystackService: Angular4PaystackService) {}

async pay() {
public async pay() {
let errorText = '';
if (this.paystackOptions && Object.keys(this.paystackOptions).length >= 2) {
errorText = this.valdateInput(this.paystackOptions);
Expand All @@ -57,14 +57,14 @@ export class Angular4PaystackEmbedComponent implements OnInit {
return '';
}

valdateInput(obj: PaystackOptions) {
private valdateInput(obj: PaystackOptions) {
if (!this.callback.observers.length) {
return 'ANGULAR-PAYSTACK: Insert a callback output like so (callback)=\'PaymentComplete($event)\' to check payment status';
}
return this.paystackService.checkInput(obj);
}

generateOptions(obj: PaystackOptions) {
private generateOptions(obj: PaystackOptions) {
this._paystackOptions = this.paystackService.getPaystackOptions(obj);
this._paystackOptions.onClose = () => {
if (this.onClose.observers.length) {
Expand All @@ -76,7 +76,7 @@ export class Angular4PaystackEmbedComponent implements OnInit {
};
}

async ngOnInit() {
public async ngOnInit() {
console.error(
'ANGULAR-PAYSTACK: The paystack embed option is deprecated. Please use the paystack component or directive'
);
Expand Down