Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodeprintcontroller.cs): #29 Line offset bug #85

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

TNThomas
Copy link
Contributor

Horizontal lines moved up 2 pixels. Vertical lines underneath boxes extended by 1 pixel.

fix #29

…ent breaking lines in viewport

Horizontal lines moved up 2 pixels. Vertical lines underneath boxes extended by 1 pixel.

fix ashblue#29
@ashblue
Copy link
Owner

ashblue commented Jan 24, 2023

I've got a few edge case projects to test this against. Should have time this weekend 👍

@ashblue
Copy link
Owner

ashblue commented Jan 30, 2023

This kinda fixes it, but looks like it introduces a gap that shouldn't be there. Will show up more clearly when dark mode gets added. Should be a continuous line. Hopefully easy to fix

image

Tabris Thomas added 2 commits January 30, 2023 08:52
…ent breaking lines in viewport

Vertical lines above boxes moved up by 1 pixel.

fix ashblue#29
…thub.com/TNThomas/fluid-behavior-tree into feature/29-minor-editor-rendering-glitch

# Conflicts:
#	Assets/com.fluid.behavior-tree/Editor/BehaviorTree/Printer/NodePrintController.cs
@TNThomas
Copy link
Contributor Author

Found and fixed one instance of broken lines, but it didn't look like the ones in your screenshot (not sure how you produced those).

@ashblue
Copy link
Owner

ashblue commented Feb 4, 2023

I'll take a look today. See if the issue went away

@ashblue
Copy link
Owner

ashblue commented Feb 5, 2023

Definitely seeing the issue still in the built in example trees. Can you post a screenshot of how it looks on your end? Also what OS are you using?

@TNThomas
Copy link
Contributor Author

TNThomas commented Feb 5, 2023

I am using Windows 11. I'll get a screenshot for you after GGJ is over

TNThomas added 2 commits February 6, 2023 20:29
…thub.com/TNThomas/fluid-behavior-tree into feature/29-minor-editor-rendering-glitch

# Conflicts:
#	Assets/com.fluid.behavior-tree/Editor/BehaviorTree/Printer/NodePrintController.cs
@TNThomas
Copy link
Contributor Author

TNThomas commented Feb 7, 2023

image

@ashblue
Copy link
Owner

ashblue commented Mar 4, 2023

Weird... I'll have to dig into this a bit more. Sorry for the delay getting this in.

@ashblue
Copy link
Owner

ashblue commented Apr 13, 2024

Might have an idea what's causing this, should get addressed in the next bundle of patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor editor rendering glitch
2 participants