Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure primary key migrations are generated with prefix for multit… #488

Merged
merged 5 commits into from
Feb 21, 2025
Merged

Make sure primary key migrations are generated with prefix for multit… #488

merged 5 commits into from
Feb 21, 2025

Conversation

m0rt3nlund
Copy link
Contributor

…enancy

Contributor checklist

  • Bug fixes include regression tests
  • Features include unit/acceptance tests

@zachdaniel
Copy link
Contributor

Got some warnings to fix. There will be one failing test you can ignore though.

@m0rt3nlund
Copy link
Contributor Author

I pulled in the latest version of ash_postgres but I still only got a credo warning, which I fixed. But the tests that are failing Is not related to my change as far as I can see?
I have tried to find the reason for the failing tests, but it also seem very strange that they are failing now?

@zachdaniel zachdaniel merged commit 5e3f12d into ash-project:main Feb 21, 2025
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m0rt3nlund @zachdaniel