This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
Keep showing loading before image really loaded #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to success but image not yet loaded
sontaemoo
pushed a commit
to sontaemoo/react-native-image-viewer
that referenced
this pull request
Jun 24, 2021
This was referenced Jun 24, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the first time I launch my app, this component has seconds rendering empty view after loading hide and before image really loaded, especially when the image is large. This merge request simply adds loading after status changes to success and hides loading immediately after onLoad event emits.