Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed navigating to a longer next/previous month #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed navigating to a longer next/previous month #48

wants to merge 2 commits into from

Conversation

AndreVME
Copy link

  • When the calendar loads in a month that is short, say February, the endsAt is set as the 28th (unless it's a leap year)
  • When you hit goToPreviousMonth to go to January, the package is doing $this->endsAt->subMonthNoOverflow() which is keeping the end date for January as 28th
  • This makes the grid not load the final week

Added tests to illustrate the scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AndreVME