Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up Bayes Factor stat and plotting functions #2406

Merged
merged 10 commits into from
Jan 9, 2025

Conversation

mpmbq2
Copy link
Contributor

@mpmbq2 mpmbq2 commented Dec 24, 2024

Description

This PR addresses issue #2402.

The plot_bf function computes the Bayes Factor statistic, and plots the result. However, it is also useful to just compute the Bayes Factor without making the plot.

This PR splits the Bayes Factor computation off to a function arviz.stats.bayes_factor, which is called by arviz.plots.plot_bf to make the plot.

I see that this PR can't be automatically merged, but it's not immediately clear to me why.

Checklist

  • Follows official PR format
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

📚 Documentation preview 📚: https://arviz--2406.org.readthedocs.build/en/2406/

@aloctavodia aloctavodia merged commit 0fc1117 into arviz-devs:main Jan 9, 2025
10 checks passed
@aloctavodia
Copy link
Contributor

thanks @mpmbq2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants