Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom groups without warnings #2401

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Dec 9, 2024

Description

Only emit a warning for custom groups when explicitly requested.

As InferenceData gets more uses, data related to the model but not specifically defined
in the schema is also stored as independent groups, which is perfectly fine and doesn't break
anything but it is annoying to get all the warnings or having to silence them constantly.
Moreover, this is set to not happen in arviz-base so it will also align behaviour.

Checklist

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

📚 Documentation preview 📚: https://arviz--2401.org.readthedocs.build/en/2401/

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.81%. Comparing base (529d795) to head (a810882).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2401   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files         124      124           
  Lines       12883    12884    +1     
=======================================
+ Hits        11184    11185    +1     
  Misses       1699     1699           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OriolAbril OriolAbril merged commit 9dbd43e into arviz-devs:main Dec 19, 2024
12 checks passed
@OriolAbril OriolAbril deleted the no_warnings_custom_groups branch December 19, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant