Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustify preview module #2398

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Nov 28, 2024

Description

Improve behaviour of arviz.preview module

Checklist

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

📚 Documentation preview 📚: https://arviz--2398.org.readthedocs.build/en/2398/

catch import errors so an existing arviz-xyz
broken installation doesn't affect regular arviz
@OriolAbril OriolAbril marked this pull request as ready for review December 5, 2024 01:44
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 46.42857% with 15 lines in your changes missing coverage. Please review.

Project coverage is 86.72%. Comparing base (529d795) to head (d4b25a0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
arviz/preview.py 46.42% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2398      +/-   ##
==========================================
- Coverage   86.81%   86.72%   -0.10%     
==========================================
  Files         124      124              
  Lines       12883    12907      +24     
==========================================
+ Hits        11184    11193       +9     
- Misses       1699     1714      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OriolAbril OriolAbril merged commit adb2fef into arviz-devs:main Dec 19, 2024
11 of 12 checks passed
@OriolAbril OriolAbril deleted the robustify_preview branch December 19, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant