Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove conditional_jit from plot_forest label_idx #2319

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Mar 11, 2024

Description

Related to #2313. This should fix the bug mentioned in that issue.
With the recent improvements to numba it has become more performant yet more restrictive
to support the performance improvements.

plot_forest had a function that was already using forceobj=True, and now due to the
combination of lists, dicts and .append, numba rejects compiling it (probably wasn't doing much
to begin with in previous versions). So I have removed the conditional_jit part.

Checklist

  • Does the PR follow official PR format?
  • Is the code style correct (follows pylint and black guidelines)?
  • Is the fix listed in the Maintenance and fixes
    section of the changelog?

📚 Documentation preview 📚: https://arviz--2319.org.readthedocs.build/en/2319/

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.79%. Comparing base (82ea6e4) to head (c869d9a).

Files Patch % Lines
arviz/data/io_pystan.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2319   +/-   ##
=======================================
  Coverage   86.79%   86.79%           
=======================================
  Files         123      123           
  Lines       12728    12722    -6     
=======================================
- Hits        11047    11042    -5     
+ Misses       1681     1680    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drbenvincent
Copy link
Contributor

I can confirm that this fixes the bug I was encountering (#2313)

@OriolAbril OriolAbril merged commit 3fc5962 into main Mar 12, 2024
10 of 11 checks passed
@OriolAbril OriolAbril deleted the numba_forest branch March 12, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants