Support for reading offset from a file #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement a use case of a Java application running in Kubernetes, I needed to be able to dynamically set the time offset from outside the Java process.
Every time
System.currentTimeMillis()is called, the offset is now read from the file specified in the Java propertyfaketime.offset.fileinstead of directly from the propertyfaketime.offset.seconds. If the property is not set, the offset infaketime.offset.secondsis used as before.This enables one to dynamically set the offset in a Kubernetes ConfigMap object, which is mounted in the Java application container as a file.