Monitor timeout bugfix v2 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2014b87. A better correction will follow.
This is a more correct fix than that reverted in the (now reverted) commit 2014b87 ("Do not apply udev-monitor-set-timeout! to #f values") to correctly handle the #:timeout-usecs keyword argument, which should not be specified as #f per Guile's 'select' API. * modules/udev/monitor.scm (make-udev-monitor): Avoid applying udev-monitor-set-timeout! to a #f 3rd argument (usecs).
Apteryks
force-pushed
the
monitor-timeout-bugfix-v2
branch
from
8f62a51 to
ea2abcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a better fix than my previous fix (already merged, thanks!).
Sorry for not producing it in my first submission :-).