Clang tidy/auto ptr #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 28, 2018 18:29
- remaining std::auto_ptr - redundant std::move when returning from a function - (consider using std::unique_ptr instead of naked new)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Fist I would like to thank you for a great piece of software and also for making it more available thanks to the recent licence changes.
I am trying to modernize CppCMS (primarily get rid of the deprecated
std::auto_ptr).I have used clang-tidy 5.0 with the modernize-replace-auto-ptr check, so the first commit is simply output from the tool.
The second commit contains my manual changes in order to fix the build (with gcc 7 in c++14 mode) and subsequently fix all tests.
So this pull request contains mainly the following changes:
std::auto_ptrhas been replaced withstd::unique_ptrbooster::shared_ptrandbooster::weak_ptr(and few related classes and functions) have been replaced with aliases to std equivalents (could be solved differently - e.g. by changing the CppCMS code to use thestdclasses directly).I understand that this is the API change and so it probably could be included only to a major version.
I just wanted to share my effort and hear your opinion (I am probably going to make more changes/modernizations based on other clang-tidy suggestions).