feat(isProfileComplete): remove other_relevant_positions from isProfileComplete

[araujobarret]

Related to DIA-561

Removes the field other_relevant_positions from isProfileComplete. We no longer require this field as a necessary one for the completeness of the profile.

[artsy-peril]

Warnings

⚠️

The V2 schema in this PR has breaking changes with Force. Remember to update the Force schema if necessary. Type 'CareerHighlight' was removed Type 'CertificateOfAuthenticityDetails' was removed Type 'OfferableActivity' was removed Type 'PartnerOfferSourceEnum' was removed Type 'CollectorProfileUpdatePromptNotificationItem' was removed Type 'ArtworkConsignmentSubmissionConnection' was removed Type 'ArtworkConsignmentSubmissionEdge' was removed Type 'CreateCareerHighlightInput' was removed Type 'CreateCareerHighlightPayload' was removed Type 'CreateCareerHighlightSuccessResponseOrError' was removed Type 'CreateCareerHighlightFailure' was removed Type 'CreateCareerHighlightSuccess' was removed Type 'DeleteCareerHighlightInput' was removed Type 'DeleteCareerHighlightPayload' was removed Type 'DeleteCareerHighlightSuccessOrErrorType' was removed Type 'DeleteCareerHighlightFailure' was removed Type 'DeleteCareerHighlightSuccess' was removed Type 'ArtworkSignatureTypeEnum' was removed Type 'UpdateCareerHighlightInput' was removed Type 'UpdateCareerHighlightPayload' was removed Type 'UpdateCareerHighlightsSuccessResponseOrError' was removed Type 'UpdateCareerHighlightFailure' was removed Type 'UpdateCareerHighlightSuccess' was removed Type 'UpdatePartnerShowMutationInput' was removed Type 'UpdatePartnerShowMutationPayload' was removed Type 'UpdatePartnerShowResponseOrError' was removed Type 'UpdatePartnerShowFailure' was removed Type 'UpdatePartnerShowSuccess' was removed Field 'commerceAbandonedOrders' was removed from object type 'Query' Argument 'excludeArtworkIds: [String]' was removed from field 'Query.artworksForUser' Argument 'sellerId: String' was removed from field 'Query.commerceBuyerActivity' Field 'certificateOfAuthenticityDetails' was removed from object type 'Artwork' Field 'framedDepth' was removed from object type 'Artwork' Field 'framedHeight' was removed from object type 'Artwork' Field 'framedMetric' was removed from object type 'Artwork' Field 'framedWidth' was removed from object type 'Artwork' Field 'isFramed' was removed from object type 'Artwork' Field 'lastOfferableActivityAt' was removed from object type 'Artwork' Field 'offerableActivity' was removed from object type 'Artwork' Field 'recentAbandonedOrdersCount' was removed from object type 'Artwork' Field 'signatureDetails' was removed from object type 'Artwork' Field 'careerHighlights' was removed from object type 'Artist' Enum value 'LAST_OFFERABLE_ACTIVITY_AT_DESC' was removed from enum 'ArtworkSorts' Argument 'includeAllFields: Boolean' was removed from field 'Partner.artistsConnection' Argument 'visibilityLevels: [Visibility]' was removed from field 'Partner.artworksConnection' Field 'image' was removed from object type 'ArtistPartnerEdge' Field 'imageUrl' was removed from object type 'ArtistPartnerEdge' Field 'isHiddenInPresentationMode' was removed from object type 'ArtistPartnerEdge' Field 'unlistedArtworks' was removed from object type 'PartnerArtistCounts' Field 'lastUpdatePromptAt' was removed from object type 'InquirerCollectorProfile' Field 'summaryParagraph' was removed from object type 'InquirerCollectorProfile' Field 'lastUpdatePromptAt' was removed from object type 'CollectorProfileType' Field 'summaryParagraph' was removed from object type 'CollectorProfileType' Field 'image' was removed from object type 'PartnerArtistEdge' Field 'imageUrl' was removed from object type 'PartnerArtistEdge' Field 'isHiddenInPresentationMode' was removed from object type 'PartnerArtistEdge' Field 'image' was removed from object type 'PartnerArtist' Field 'imageUrl' was removed from object type 'PartnerArtist' Field 'isHiddenInPresentationMode' was removed from object type 'PartnerArtist' Argument 'forSale: Boolean' was removed from field 'Collection.artworksConnection' Argument 'priceMax: Int' was removed from field 'Collection.artworksConnection' Argument 'priceMin: Int' was removed from field 'Collection.artworksConnection' Field 'isActive' was removed from object type 'PartnerOffer' Field 'source' was removed from object type 'PartnerOffer' Field 'lastTransactionFailureCode' was removed from interface 'CommerceOrder' Field 'myCollectionArtwork' was removed from object type 'ConsignmentSubmission' Field 'myCollectionArtworkID' was removed from object type 'ConsignmentSubmission' Field 'source' was removed from object type 'ConsignmentSubmission' Field 'userPhoneNumber' was removed from object type 'ConsignmentSubmission' Field 'totalCount' was removed from object type 'ConversationConnection' Field 'submissionsConnection' was removed from object type 'Me' Argument 'includeOnlyTargetSupply: Boolean' was removed from field 'Me.myCollectionConnection' Member 'CollectorProfileUpdatePromptNotificationItem' was removed from Union type 'NotificationItem' Enum value 'COLLECTOR_PROFILE_UPDATE_PROMPT' was removed from enum 'NotificationTypesEnum' Field 'isActive' was removed from object type 'PartnerOfferToCollector' Field 'source' was removed from object type 'PartnerOfferToCollector' Field 'StaticContent.specialistBios' changed type from '[SpecialistBio!]' to '[SpecialistBio]' Field 'SpecialistBio.bio' changed type from 'String!' to 'String' Field 'SpecialistBio.email' changed type from 'String!' to 'String' Field 'SpecialistBio.firstName' changed type from 'String!' to 'String' Field 'SpecialistBio.image' changed type from 'Image!' to 'Image' Field 'SpecialistBio.jobTitle' changed type from 'String!' to 'String' Field 'SpecialistBio.name' changed type from 'String!' to 'String' Field 'commerceOrders' was removed from object type 'Viewer' Argument 'excludeArtworkIds: [String]' was removed from field 'Viewer.artworksForUser' Field 'convectionCreateConsignmentSubmission' was removed from object type 'Mutation' Field 'createCareerHighlight' was removed from object type 'Mutation' Field 'deleteCareerHighlight' was removed from object type 'Mutation' Field 'updateCareerHighlight' was removed from object type 'Mutation' Field 'updatePartnerShow' was removed from object type 'Mutation' Input field 'impulseConversationId' was removed from input object type 'CommerceCreatePartnerOfferOrderInput' Input field 'additionalInformation' was removed from input object type 'MyCollectionCreateArtworkInput' Input field 'coaByAuthenticatingBody' was removed from input object type 'MyCollectionCreateArtworkInput' Input field 'coaByGallery' was removed from input object type 'MyCollectionCreateArtworkInput' Input field 'conditionDescription' was removed from input object type 'MyCollectionCreateArtworkInput' Input field 'framedDepth' was removed from input object type 'MyCollectionCreateArtworkInput' Input field 'framedHeight' was removed from input object type 'MyCollectionCreateArtworkInput' Input field 'framedMetric' was removed from input object type 'MyCollectionCreateArtworkInput' Input field 'framedWidth' was removed from input object type 'MyCollectionCreateArtworkInput' Input field 'hasCertificateOfAuthenticity' was removed from input object type 'MyCollectionCreateArtworkInput' Input field 'isFramed' was removed from input object type 'MyCollectionCreateArtworkInput' Input field 'signatureDetails' was removed from input object type 'MyCollectionCreateArtworkInput' Input field 'signatureTypes' was removed from input object type 'MyCollectionCreateArtworkInput' Input field 'additionalInformation' was removed from input object type 'MyCollectionUpdateArtworkInput' Input field 'coaByAuthenticatingBody' was removed from input object type 'MyCollectionUpdateArtworkInput' Input field 'coaByGallery' was removed from input object type 'MyCollectionUpdateArtworkInput' Input field 'conditionDescription' was removed from input object type 'MyCollectionUpdateArtworkInput' Input field 'framedDepth' was removed from input object type 'MyCollectionUpdateArtworkInput' Input field 'framedHeight' was removed from input object type 'MyCollectionUpdateArtworkInput' Input field 'framedMetric' was removed from input object type 'MyCollectionUpdateArtworkInput' Input field 'framedWidth' was removed from input object type 'MyCollectionUpdateArtworkInput' Input field 'hasCertificateOfAuthenticity' was removed from input object type 'MyCollectionUpdateArtworkInput' Input field 'isFramed' was removed from input object type 'MyCollectionUpdateArtworkInput' Input field 'signatureDetails' was removed from input object type 'MyCollectionUpdateArtworkInput' Input field 'signatureTypes' was removed from input object type 'MyCollectionUpdateArtworkInput' Input field 'promptedForUpdate' was removed from input object type 'UpdateCollectorProfileInput' Field 'lastUpdatePromptAt' was removed from object type 'UpdateCollectorProfilePayload' Field 'summaryParagraph' was removed from object type 'UpdateCollectorProfilePayload' Field 'lastTransactionFailureCode' was removed from object type 'CommerceBuyOrder' Field 'lastTransactionFailureCode' was removed from object type 'CommerceOfferOrder'

Generated by 🚫 dangerJS against b337cae

[egdbear]

🚢

[egdbear]

question: Why don't we add the isVerified here?

[araujobarret]

let's see what the folks think about the discussion here