[ONYX-454] feat(notifications/activity): expose artworks within PartnerShowOpenedActivity #5351
Conversation
…dActivity Artworks are currently exposed for `SavedSearchHitActivity` and `ArtworkPublishedActivity` events. While other types do not currently include artwork IDs within the events `object_ids` structure, we can utilize other data loaders to fetch associated artworks. This also includes a switch to `filterArtworksLoader` which supports more filter params and is a bit more performant than `artworksLoader`, primarily due to our use of Elasticsearch under the hood.
|
cc/ @olerichter00 @nickskalkin @anandaroop as a conversation starter. It think the primary risk of this approach is that it'll make This also intentionally picks out the first object of the activity entry, whether it's a show (or viewing room if this approach is expanded), and only includes artworks from that first object. |
|
Makes sense, and the tradeoff re: switching but also now using the more performant loader sounds plausible. Since we can't predict net performance, we can always keep an eye on this DD entry. |
|
looks good to me! I don't understand though why this change should make the query slower 🤔 |
I suppose you're right — this shouldn't be any slower than the current |
olerichter00
changed the title
|
ONYX-454
Artworks are currently exposed for
SavedSearchHitActivityandArtworkPublishedActivityevents. While other types do not currently include artwork IDs within the eventsobject_idsstructure, we can utilize other data loaders to fetch associated artworks.This also includes a switch to
filterArtworksLoaderwhich supports more filter params and is a bit more performant thanartworksLoader, primarily due to our use of Elasticsearch under the hood.