Bulk update mutation tweaks #4277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a note on that peril warning above ☝️ since volt is the only consumer of these fields, this should be a-ok |
Mitch-Henson
previously requested changes
Aug 4, 2022
Comment on lines
+3208
to
+3211
| type BulkUpdatePartnerArtworksResponse { | ||
| count: Int | ||
| ids: [String] | ||
| } |
There was a problem hiding this comment.
Shouldn't errors also be here? It is a part of the response and we seem to be using it in the formattedReturn
ansor4
reviewed
Aug 4, 2022
|
|
||
| const formattedReturn = { | ||
| updatedPartnerArtworks: { count: gravityResponse.success, ids: [] }, | ||
| skippedPartnerArtworks: gravityResponse.errors, |
There was a problem hiding this comment.
@lilyfromseattle maybe let's be explicit here so future devs don't have to go digging into the gravity response format
skippedPartnerArtworks: { count: gravityResponse.errors.count, ids: gravityResponse.errors.ids }
ansor4
approved these changes
Aug 5, 2022
ansor4
dismissed
Mitch-Henson’s stale review
Currently blocking merging, which we need to unblock Lily's Volt work!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ansor4 and I made some tweaks to the bulk update mutation to simplify the structure and make the naming more consistent. If this looks all good to you I can continue with my front end changes once its merged and released! If there are any issues or questions we can discuss at the sync I scheduled for tomorrow morning.