Merge pull request #5806 from artsy/dblandin/schema-error-null-my-col…

…lection-artwork-id

fix: avoid schema error when Submission#myCollectionArtworkID is null

src/lib/stitching/convection/__tests__/stitching.test.ts

@@ -126,3 +126,18 @@ it("resolves the myCollectionArtwork field on Consignment Submission", async ()
     })
   )
 })
+
+it("resolves null for the myCollectionArtwork field on Consignment Submission if myCollectionArtworkID is null", async () => {
+  const { resolvers } = await getConvectionStitchedSchema()
+  const { myCollectionArtwork } = resolvers.ConsignmentSubmission
+  const info = { mergeInfo: { delegateToSchema: jest.fn() } }
+
+  const response = myCollectionArtwork.resolve(
+    { myCollectionArtworkID: null },
+    {},
+    {},
+    info
+  )
+
+  expect(response).toEqual(null)
+})

src/lib/stitching/convection/v2/stitching.ts

@@ -43,6 +43,9 @@ export const consignmentStitchingEnvironment = (
         fragment: `fragment SubmissionArtwork on ConsignmentSubmission { myCollectionArtworkID }`,
         resolve: (parent, _args, context, info) => {
           const id = parent.myCollectionArtworkID
+
+          if (!id) return null
+
           return info.mergeInfo.delegateToSchema({
             schema: localSchema,
             operation: "query",