build(tools): use xcode 15 #9323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brainbicycle
changed the title
|
Gonna hold off until there is a clearer answer around performance. |
pvinis
reviewed
Sep 27, 2023
brainbicycle
changed the title
|
this is finally ready to go! |
gkartalis
approved these changes
Nov 22, 2023
brainbicycle
added a commit
that referenced
this pull request
Nov 30, 2023
This reverts commit 8d22776.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves PHIRE-275
Description
Depends on: #9322 which should be merged first ✅
Update ci + docs to use Xcode 15.
Issues with ruby install in ci, updating ruby dep to default installed, 2.7.4 is end of life so we should move off anyway.
There seem to be some known performance issues with running unit tests on Xcode 15, I am also seeing the iOS tests time out it seems waiting for simulator to launch:😬https://discuss.circleci.com/t/severe-performance-problems-with-xcode-15/49205/17
We may want to hold off
Edit: The 15.1 beta issues still has performance regressions but no longer times out, since most devs are on 15 at this point think makes sense to update, will keep an eye out of there are updated Xcode images in future.
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.