Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(masonry): replace partners artworks with tabs.masonry #9293

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

gkartalis
Copy link
Member

@gkartalis gkartalis commented Sep 20, 2023

This PR resolves PHIRE-255

Description

Replace partners artworks with tabs.masonry

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • replace partners artworks with tabs.masonry - gkartalis

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@gkartalis gkartalis self-assigned this Sep 20, 2023
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Sep 20, 2023

This PR contains the following changes:

  • Cross-platform user-facing changes (replace partners artworks with tabs.masonry - gkartalis)

Generated by 🚫 dangerJS against 55f786e

@gkartalis
Copy link
Member Author

By having a look on #9135 and this one I think we might need to start abstracting some things to be reused. Still wip though

@gkartalis gkartalis marked this pull request as ready for review September 21, 2023 09:19
@gkartalis gkartalis assigned brainbicycle and unassigned gkartalis Sep 21, 2023
Copy link
Contributor

@brainbicycle brainbicycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐎 looking good!

@gkartalis gkartalis merged commit df50cd8 into main Sep 22, 2023
8 checks passed
@gkartalis gkartalis deleted the gkartalis/partner-masonry branch September 22, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants