feat(ONYX-253): create suggested artworks screen

[dariakoko]

This PR resolves ONYX-253

Description

Create a modal displaying similar works
We should display only 10 artworks
By pressing on the artwork navigate to the artwork screen

All data available	Empty state	Error state	Placeholder for the pills	Placeholder for the grid
			)

PR Checklist

• I have tested my changes on iOS and Android.
• I hid my changes behind a feature flag, or they don't need one.
• I have included screenshots or videos, or I have not changed the UI.
• I have added tests, or my changes don't require any.
• I added an app state migration, or my changes do not require one.
• I have documented any follow-up work that this PR will require, or it does not require any.
• I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

• I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates

Changelog updates

Cross-platform user-facing changes

• create suggested artworks screen -daria

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

[ArtsyOpenSource]

This PR contains the following changes:

• Cross-platform user-facing changes (create suggested artworks screen -daria)

Generated by 🚫 dangerJS against c53221b

[damassi]

@dariakoko - can you 🙏 update the PR with a full description? We shouldn't depend on external JIRA ticket links to provide relevant context in a PR.

Folks reviewing -- Feeling somewhat 😓 having to ping PR after PR about this, #dev channel, etc. It should be flagged and discussed amongst product teams and made an immutable habit.

[dariakoko]

@dariakoko - can you 🙏 update the PR with a full description? We shouldn't depend on external JIRA ticket links to provide relevant context in a PR.

Sure. I have just marked it as ready for review. Next time will update the details first and then change the status

[damassi]

ty! didn't realize it wasn't yet ready to review, saw PR comments and so on. All good. And please spread the word 😄

[nickskalkin]

cool! Left some questions, let me know if I should add more details!

[nickskalkin]

question: is there a reason why we pass empty callbacks here?

[dariakoko]

Not at all, I just wanted to reuse the types we use for the alert creation flow. After refactoring it doesn't make sense any more - removed, added an interface with only aggregations, attributes, entity to the file

[MounirDhahri]

Hey @dariakoko, I see you're still pushing to the PR. Is it ready for review? if not would you mind changing it to a draft PR or adding [WIP] to the title.

[dariakoko]

@MounirDhahri Ready for review, pushed the latest changes just now

[nickskalkin]

All good, I left 1 code related suggestion and 1 thing I think we should fix before merging - hide the button if there are no artworks to suggest

well done! 👍

[nickskalkin]

suggestion: there is a a new query you could use instead, which doesn't require attributes (all logic is on metaphysics side):

	artwork(id: "banksy-di-faced-tenner-232") {
		savedSearch {	
			suggestedArtworksConnection(first: 10) {
				edges {
					node {
						title
					}
				}
			}
		}
	}

[dariakoko]

Good to know, would be nice to use it
I tried it, but it returns an empty array of nodes, so I'd stick only with the totalCount in this commit
We could look into this together if you're interested

[MounirDhahri]

Really nice PR! great work Daria

[MounirDhahri]

issue: using the same fields here as in

eigen/src/app/Components/Artist/ArtistArtworks/CreateArtworkAlertModal.tsx

Line 29 in 0003f6f

fragment CreateArtworkAlertModal_artwork on Artwork {

makes me think we should consolidate this into one fragment instead of copying it. This way this code is going to be more robust if we introduce future changes

[nickskalkin]

👍

[MounirDhahri]

LGTM. Just a small suggestion