Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use network-only fetch policy mode for artwork list screen #8794

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

dimatretyak
Copy link
Contributor

@dimatretyak dimatretyak commented Jun 1, 2023

This PR resolves []

Notion card: https://www.notion.so/artsy/When-an-artwork-list-is-open-and-an-artwork-is-removed-from-the-list-the-update-is-not-reflected-imm-fa6851d0c519441a90e6519f95dde7e0

Demo

Before After
before.mp4
after.mp4

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • use network-only fetch policy mode for artwork list screen - dimatretyak

Need help with something? Have a look at our docs, or get in touch with us.

@dimatretyak dimatretyak self-assigned this Jun 1, 2023
@dimatretyak dimatretyak marked this pull request as ready for review June 1, 2023 14:41
@dimatretyak dimatretyak merged commit 51aed4e into main Jun 5, 2023
@dimatretyak dimatretyak deleted the dimatretyak/chore/artwork-list-improvement branch June 5, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant